-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed cyclic lr state dict #1469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaydeci
requested review from
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
September 18, 2023 12:11
BloodAxe
reviewed
Sep 19, 2023
BloodAxe
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…yclic_lr_state_dict # Conflicts: # src/super_gradients/training/utils/checkpoint_utils.py
BloodAxe
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e_dict' into bugfix/SG-000_fix_cyclic_lr_state_dict
BloodAxe
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fixed cyclic lr state dict * fixed circular import * local import of torch_version_is_greater_or_equal * Fix missing function after merge --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> (cherry picked from commit b56fad8)
BloodAxe
added a commit
that referenced
this pull request
Oct 12, 2023
* fixed cyclic lr state dict * fixed circular import * local import of torch_version_is_greater_or_equal * Fix missing function after merge --------- Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com> (cherry picked from commit b56fad8) Co-authored-by: Shay Aharon <80472096+shaydeci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.